D16429: [WIP] Rewrite of Scheduler planning

Yuri Chornoivan noreply at phabricator.kde.org
Sun Oct 28 15:47:02 GMT 2018

yurchor added inline comments.


> scheduler.cpp:977
>      jobEvaluationOnly = true;
> -    evaluateJobs();
> +    evaluateJobs();;
>  }

Is this second semicolon important?

> scheduler.cpp:1737
> +     *
> +     * Second solution has the algorithm moving schedules around. The only case this is allowed is the alitude/priority sorting. Else, this is all user-based.
> +     *

Typo: alitude->altitude

> scheduler.cpp:2333
> +
> +    // FIXME: Dark sky score should consider the middle of the local night as best value.
> +    // FIXME: Current algorithm uses the dawn and dusk of today, instead of the day of the observation.

Typo: best->the best

> scheduler.h:445
> +         * @brief getDarkSkyScore Get the dark sky score of a date and time. The further from dawn the better.
> +         * @param when date and time to check the dark sky score, now if omitted
> +         * @return Dark sky score. Daylight get bad score, as well as pre-dawn to dawn.

Actually, this should be

  * param observationDateTime when ...

to not confusing doxygen.

  R321 KStars


To: TallFurryMan, mutlaqja, wreissenberger
Cc: yurchor, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181028/ea911abe/attachment.html>

More information about the kde-edu mailing list