D9395: Configuration capabilities for online dictionaries

[Tomaz Canabrava]

tcanabrava requested changes to this revision.
tcanabrava added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: kde-edu.

INLINE COMMENTS

> dictionaryeditor.h:41
> +     */
> +    enum EntryMode {
> +        AddOnly,

enum class short ?

> parley.kcfg:401
> +      <entry name="Dictionaries" type="String">
> +          <default>{"id":"1","name":"De-Es Beolingus","source":"de","target":"es","url":"http://beolingus.org/dings.cgi?service=dees&query=\\{@}"}<<{"id":"2","name":"De-En Beolingus","source":"de","target":"en","url":"http://beolingus.org/dings.cgi?query=\\{@}"}<<{"id":"3","name":"De-En Leo","source":"de","target":"en","url":"http://dict.leo.org/?search=\\{@}"}<<{"id":"4","name":"De-Es Leo","source":"de","target":"es","url":"http://dict.leo.org/?lp=esde&search=\\{@}"}<<{"id":"5","name":"De-Fr Leo","source":"de","target":"fr","url":"http://dict.leo.org/?lp=frde&search=\\{@}"}<<{"id":"6","name":"Ru-En Multitran","url":"http://multitran.ru/c/m.exe?SHL=1&CL=1&l1=1&s=\\{@}","source":"ru","target":"en"}<<{"id":"7","name":"Ru-De Multitran","url":"http://multitran.ru/c/m.exe?SHL=1&CL=1&l1=3&s=\\{@}","source":"ru","target":"de"}<<{"id":"8","name":"Ru-Fr Multitran","url":"http://multitran.ru/c/m.exe?SHL=1&CL=1&l1=4&s=\\{@}","source":"ru","target":"fr"}<<{"id":"9","name":"Heinzelnisse","url":"http://heinzelnisse.info/dict?setOptions=true&searchItem=\\{@}&dictDeNoSearch=on&dictNoDeSearch=on&dictExactSearch=on&dictPhoneticSearch=on&wikiSearch=on&dictNynorskSearch=on&dictBokmaalSearch=checked&forumKeywordSearch=on&suggestion=on"","source":"no","target":"de"}<<{"id":"10","name":"Glosbe (en-es)","source":"en","target":"es","url":"https://glosbe.com/en/es/ \\{@}"}<<{"id":"11","name":"Glosbe (es-en)","source":"es","target":"en","url":"https://glosbe.com/es/en/ \\{@}"}</default>
> +      </entry>

This is way better if it's a json file outside of the kcfg group.
default-dictionaries.json or something.

REPOSITORY
  R340 Parley

REVISION DETAIL
  https://phabricator.kde.org/D9395

To: dkardarakos, #kde_edu, tcanabrava
Cc: kde-edu, tcanabrava, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181102/5064820a/attachment.html>