<table><tr><td style="">tcanabrava requested changes to this revision.<br />tcanabrava added inline comments.<br />This revision now requires changes to proceed.<br />Herald added a subscriber: kde-edu.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9395">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9395#inline-90424">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dictionaryeditor.h:41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">enum</span> <span class="n">EntryMode</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">AddOnly</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">enum class short ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9395#inline-90425">View Inline</a><span style="color: #4b4d51; font-weight: bold;">parley.kcfg:401</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <entry name="Dictionaries" type="String">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <default>{"id":"1","name":"De-Es Beolingus","source":"de","target":"es","url":"http://beolingus.org/dings.cgi?service=dees&query=\\{@}"}<<{"id":"2","name":"De-En Beolingus","source":"de","target":"en","url":"http://beolingus.org/dings.cgi?query=\\{@}"}<<{"id":"3","name":"De-En Leo","source":"de","target":"en","url":"http://dict.leo.org/?search=\\{@}"}<<{"id":"4","name":"De-Es Leo","source":"de","target":"es","url":"http://dict.leo.org/?lp=esde&search=\\{@}"}<<{"id":"5","name":"De-Fr Leo","source":"de","target":"fr","url":"http://dict.leo.org/?lp=frde&search=\\{@}"}<<{"id":"6","name":"Ru-En Multitran","url":"http://multitran.ru/c/m.exe?SHL=1&CL=1&l1=1&s=\\{@}","source":"ru","target":"en"}<<{"id":"7","name":"Ru-De Multitran","url":"http://multitran.ru/c/m.exe?SHL=1&CL=1&l1=3&s=\\{@}","source":"ru","target":"de"}<<{"id":"8","name":"Ru-Fr Multitran","url":"http://multitran.ru/c/m.exe?SHL=1&CL=1&l1=4&s=\\{@}","source":"ru","target":"fr"}<<{"id":"9","name":"Heinzelnisse","url":"http://heinzelnisse.info/dict?setOptions=true&searchItem=\\{@}&dictDeNoSearch=on&dictNoDeSearch=on&dictExactSearch=on&dictPhoneticSearch=on&wikiSearch=on&dictNynorskSearch=on&dictBokmaalSearch=checked&forumKeywordSearch=on&suggestion=on"","source":"no","target":"de"}<<{"id":"10","name":"Glosbe (en-es)","source":"en","target":"es","url":"https://glosbe.com/en/es/ \\{@}"}<<{"id":"11","name":"Glosbe (es-en)","source":"es","target":"en","url":"https://glosbe.com/es/en/ \\{@}"}</default>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> </entry>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is way better if it's a json file outside of the kcfg group.<br />
default-dictionaries.json or something.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R340 Parley</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9395">https://phabricator.kde.org/D9395</a></div></div><br /><div><strong>To: </strong>dkardarakos, KDE Edu, tcanabrava<br /><strong>Cc: </strong>kde-edu, tcanabrava, narvaez, apol<br /></div>