D16324: Disable trace mode in KmPlot before deleting tracing curve from the plot

[Yuri Chornoivan]

yurchor added a comment.


  In D16324#350085 <https://phabricator.kde.org/D16324#350085>, @aacid wrote:
  
  > I think it would make more sense if the logic of the code was on View itself and not parser, i.e. parser doesn't care about views, but views care about function it's viewing.
  >
  > We already have the
  >
  >   emit functionRemoved( id );
  >
  > in that function so doing something like
  >
  > connect(XParser::self(), &Parser::functionRemoved, this, &View::functionRemoved)
  >
  > and then make the functionRemoved function do something similar to the new code you added.
  >
  > At the end "it's the same", but i think it makes more sense from an architectural point of view.
  >
  > What do you think?
  
  
  I think that
  
  1. I cannot find the place for this connect. There is already
  
    connect(XParser::self(), &XParser::functionRemoved, this, &FunctionEditor::functionsChanged);
  
  in functioneditor.cpp.
  
  2. If it will be placed in View then View should have to be acknowledged of what to remove and we again should add some public variables to do so even if we do not use them in the case when nothing's going to be removed.
  
  Any ideas? Can we avoid complete rewrite of KmPlot to fix this tiny bug?

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D16324

To: yurchor, #kde_edu
Cc: aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181102/04d4546c/attachment.html>