D13036: piano_composition, add contexts for translators.
Johnny Jazeix
noreply at phabricator.kde.org
Tue May 22 15:50:56 UTC 2018
jjazeix accepted this revision.
jjazeix added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> MultipleStaff.qml:108
> + for(var i = 0; (i < pianoBlackKeysSharp.length) && !foundNote; i++) {
> for(var j = 0; j < pianoBlackKeysSharp[i].length; j++) {
> if(pianoBlackKeysSharp[i][j][0] === noteName) {
!foundNote here too
> Piano.qml:56
> + // White key notes are from G3 to C6 when the clef is treble
> + //: Translators, the same notations follow here as described above.
> readonly property var whiteNotesTreble: [
the order should be the same but better copy/paste the comment in case the translator does not want to look for the annotation
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D13036
To: amankumargupta, #gcompris_improvements, jjazeix
Cc: jjazeix, kde-edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180522/b26e9a68/attachment.html>
More information about the kde-edu
mailing list