<table><tr><td style="">jjazeix accepted this revision.<br />jjazeix added inline comments.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13036">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13036#inline-67435">View Inline</a><span style="color: #4b4d51; font-weight: bold;">MultipleStaff.qml:108</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span class="p">(</span><span style="color: #004012">i</span> <span style="color: #aa2211"><</span> <span style="color: #004012">pianoBlackKeysSharp</span><span class="p">.</span><span style="color: #004012">length</span><span class="p">)</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span style="color: #004012">foundNote</span><span class="p">;</span> <span style="color: #004012">i</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">j</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span style="color: #004012">j</span> <span style="color: #aa2211"><</span> <span style="color: #004012">pianoBlackKeysSharp</span><span class="p">[</span><span style="color: #004012">i</span><span class="p">].</span><span style="color: #004012">length</span><span class="p">;</span> <span style="color: #004012">j</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">pianoBlackKeysSharp</span><span class="p">[</span><span style="color: #004012">i</span><span class="p">][</span><span style="color: #004012">j</span><span class="p">][</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">===</span> <span style="color: #004012">noteName</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">!foundNote here too</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13036#inline-67436">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Piano.qml:56</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #74777d">// White key notes are f<span class="bright">or</span>m G3 to C6 when the clef is treble</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// White key notes are f<span class="bright">ro</span>m G3 to C6 when the clef is treble</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">//: Translators, the same notations follow here as described above.</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #004012">readonly</span> <span style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span style="color: #aa4000">whiteNotesTreble:</span> <span class="p">[</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the order should be the same but better copy/paste the comment in case the translator does not want to look for the annotation</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13036">https://phabricator.kde.org/D13036</a></div></div><br /><div><strong>To: </strong>amankumargupta, GCompris: Improvements, jjazeix<br /><strong>Cc: </strong>jjazeix, kde-edu, GCompris: Improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>