D12949: Show only already builded result in maxima backend
noreply at phabricator.kde.org
Sun May 20 15:49:13 UTC 2018
sirgienko added inline comments.
> asemke wrote in expression.cpp:174
> why do we need these connects here at all? The rendering is blocking the GUI anyway if I see it correctly. Why not to simply call renderer->render() and then process the result in the same function? With this we can also create LatexRenderer on the stack, no need for new and deleteLater().
> Ideally the rendering of the result shouldn't be blocking. Do you see what is blocking here?
Renderer use `latex` with `KProcess`, so while `latex` works, we can do something else. For this reason, we use signal and slots with `LatexRenderer`, as I see, there isn't GUI blocking here.
> asemke wrote in expression.cpp:207
> why this delete here?
Because result ptr never used, exept of this function, so remove it for avoiding memory leacks.
> asemke wrote in expression.h:28
> In case we really need the renderer in that function, you can use forward declaration here.
To: sirgienko, asemke
Cc: kde-edu, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-edu