D12933: Update the MultipleStaff view to automatically add more staffs when more notes are added.

Johnny Jazeix noreply at phabricator.kde.org
Fri May 18 19:30:53 UTC 2018


jjazeix accepted this revision.
jjazeix added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> MultipleStaff.qml:81
> +                currentStaff = 0
> +                loadFromData(melody)
>              }

is there a way to not have to save/load every time we add a staff?

> MultipleStaff.qml:83
>              }
> -            else
> -                currentStaff++
> +            currentStaff++
>          }

there was a else before, it is normal that it is removed?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12933

To: amankumargupta, #gcompris_improvements, jjazeix
Cc: jjazeix, kde-edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180518/57d64620/attachment-0001.html>


More information about the kde-edu mailing list