D12874: Piano_composition, add an indicator to highlight the currently selected note-type, minor refactoring and indentation corrections.

Aman Kumar Gupta noreply at phabricator.kde.org
Mon May 14 17:01:35 UTC 2018

amankumargupta marked 2 inline comments as done.
amankumargupta added inline comments.


> jjazeix wrote in Piano_composition.qml:209
> why setting 0 and not just setting "visible: bar.level == 1 || bar.level == 2 ? false : true" here directly?

ahh, that's very silly of me :p Thanks! Corrected in the latest diff.

> jjazeix wrote in Piano_composition.qml:252
> I'm not sure why I used staff2, but it can probably be renamed :)

Renamed to multipleStaff

  R2 GCompris


To: amankumargupta, #gcompris_improvements
Cc: jjazeix, kde-edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180514/0fe7c90a/attachment.html>

More information about the kde-edu mailing list