D12874: Piano_composition, add an indicator to highlight the currently selected note-type, minor refactoring and indentation corrections.

[Aman Kumar Gupta]

amankumargupta added inline comments.

INLINE COMMENTS

> Piano_composition.qml:195
> -
> -                Note {
> -                    id: onlyNote

This is needed no more after refactoring.

> Piano_composition.qml:203
> +            property var noteTypes: [1, 2, 4, 8]
> +            property var noteLengthName: ["whole-note", "half-note", "quarter-note", "eighth-note"]
>  

These two variable replaces the use of onlyNote, which was removed above, else the refactoring wouldn't have been possible.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D12874

To: amankumargupta, #gcompris_improvements
Cc: kde-edu, #gcompris_improvements, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180514/7cb808fd/attachment.html>