D12504: Fix problem with first entry for scilab backend
noreply at phabricator.kde.org
Tue May 1 08:47:24 UTC 2018
sirgienko added a comment.
In D12504#256273 <https://phabricator.kde.org/D12504#256273>, @asemke wrote:
> I cannot reproduce the problem with the first expression never ending. Which expression do you use?
I have recorded a video, because it's easy to show:
F5828990: scilab-cantor-example.webm <https://phabricator.kde.org/F5828990>
As you see, first entry don't wokr fine.
You haven't this behavior?
> Also here, the behavior and the implementation is inconsistent for different backends. For some backends like maxima we have a hard coded list of keywords, for others we fetch this list from the backend. In order to make the syntax highlighting and completion possible we need to always login for such backends in Worksheet::showCompletion() which breaks the whole idea of postponing the login. With your patch you won't have, if I see it correctly, any syntax highlighting and completion until the login is done. So, for saved scilab projects and for new projects where there user wants to write down some code first and evaluate later there will be no syntax highlighting and completion.
> I'd rather also re-factor this part in Cantor. The syntax highlighting and completion should be implemented with the help of KSyntaxHighlighting as proposed in T5382 <https://phabricator.kde.org/T5382>. Once this is implemented we can remove a lot of code in Cantor and also really do the login if it's really required for evaluations.
I agree, that the implementation of highlighting is inconsistent for different backends. And yes, the scilab highlighting don't work fully before login and it's problem. I have changed highlighting, because scilab backend parses keywords for highlighting in login function and it have given me the problem with first entry and I think, it's not place for the highlighting mechanism, so I have changed it. I'm not familiar with KSyntaxHighlighter, so I'm not sure if I can help with the T5382 <https://phabricator.kde.org/T5382>, but if we start refactoring, I can take on Octave backend and do everything in my power
To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-edu