D11357: Provide global config to set number to expose children to(ref: T3173)

[Johnny Jazeix]

jjazeix added a comment.


  It's a really quick review, I just read it once.
  Have you found the cause of the segfault?

INLINE COMMENTS

> ConfigurationItem.qml:591
>      property bool isVirtualKeyboard: ApplicationSettings.isVirtualKeyboard
> +    property int numberLimit // changed here #####
>      property bool isAutomaticDownloadsEnabled: ApplicationSettings.isAutomaticDownloadsEnabled

the diff shows us the change, no need to add a comment for it

> ApplicationSettings.h:340
> +    void setNumberLimit(int newNumberlimit) {
> +        m_numberLimit = qMax(qMin(newNumberlimit, numberLimitMax()), numberLimitMin());
> +        emit numberLimitChanged();

qBound?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11357

To: rohitdas, #gcompris_improvements
Cc: jjazeix, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180328/f8fa3d7d/attachment.html>