D11588: Fix broken octave backend and debug messages small change

Alexander Semke noreply at phabricator.kde.org
Sun Mar 25 17:17:41 UTC 2018


asemke added a comment.


  In D11588#233759 <https://phabricator.kde.org/D11588#233759>, @sirgienko wrote:
  
  > `octavesession.cpp:258: else if (line.contains(m_prompt))` equals `True` all time, because `m_prompt` equals  `QRegExp(patternSyntax=0, pattern='""')` (empty regex). It means, that we don't found octave prompt, because `m_currentExpression` never equals nullptr, for some reason (we also don't set temp directory too, for the same reason). So we never reach `parseOutput` call and `m_resultString == ""` all time.
  
  
  I pushed a fix for this in 3c0251f120a13a87a21ac6abc8b53cbcfcf820f0 <https://phabricator.kde.org/R55:3c0251f120a13a87a21ac6abc8b53cbcfcf820f0>. Can you please also give it a try?
  
  P.S.: I also submitted the fix to login to octave prior to the initialization of the highlighter.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D11588

To: sirgienko, #cantor
Cc: asemke, #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180325/67377065/attachment.html>


More information about the kde-edu mailing list