<table><tr><td style="">asemke added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11588">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11588#233759" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11588#233759</a>, <a href="https://phabricator.kde.org/p/sirgienko/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@sirgienko</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p><tt style="background: #ebebeb; font-size: 13px;">octavesession.cpp:258: else if (line.contains(m_prompt))</tt> equals <tt style="background: #ebebeb; font-size: 13px;">True</tt> all time, because <tt style="background: #ebebeb; font-size: 13px;">m_prompt</tt> equals <tt style="background: #ebebeb; font-size: 13px;">QRegExp(patternSyntax=0, pattern='""')</tt> (empty regex). It means, that we don't found octave prompt, because <tt style="background: #ebebeb; font-size: 13px;">m_currentExpression</tt> never equals nullptr, for some reason (we also don't set temp directory too, for the same reason). So we never reach <tt style="background: #ebebeb; font-size: 13px;">parseOutput</tt> call and <tt style="background: #ebebeb; font-size: 13px;">m_resultString == ""</tt> all time.</p></div>
</blockquote>
<p>I pushed a fix for this in <a href="https://phabricator.kde.org/R55:3c0251f120a13a87a21ac6abc8b53cbcfcf820f0" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">3c0251f120a13a87a21ac6abc8b53cbcfcf820f0</a>. Can you please also give it a try?</p>
<p>P.S.: I also submitted the fix to login to octave prior to the initialization of the highlighter.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11588">https://phabricator.kde.org/D11588</a></div></div><br /><div><strong>To: </strong>sirgienko, Cantor<br /><strong>Cc: </strong>asemke, Cantor, KDE Edu, narvaez, apol<br /></div>