D11588: Fix broken octave backend and debug messages small change
Alexander Semke
noreply at phabricator.kde.org
Sun Mar 25 13:58:32 UTC 2018
asemke added a comment.
In D11588#233714 <https://phabricator.kde.org/D11588#233714>, @sirgienko wrote:
> > As to the fix of the actual problem you mentioned here, did you check the two lines I wrote in my previous comment? Can you please validate it also solves the problem on your side?
>
> No, it don't fix the problem. The problem is that we call `syntaxHighlighter` in the `Worksheet` constructor, which calls the `OctaveHighliter` constructor, which calls the `OctaveSession::evaluateExpression`, inside which a attempt is made to access the m_process method, which is initialized with nullptr (from `OctaveSession` constructor).
> So, for Octave, we *need* call `login` before `OctaveHighliter::constructor`, or we have seg. fault.
Yes. And this is exactly what my code snippet does - it calls loginToSession() before the constructor of OctaveHighlither is called. My snippet has to be added before the line with m_highlighter=session()->syntaxHighlighter(this); - I didn't mentioned this, I assumed it was clear.
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D11588
To: sirgienko, #cantor
Cc: asemke, #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180325/75d47738/attachment.html>
More information about the kde-edu
mailing list