D11034: CoreApplicationSettingsTest

[Johnny Jazeix]

jjazeix accepted this revision.
jjazeix added a comment.
This revision is now accepted and ready to land.


  committed in https://commits.kde.org/gcompris/9a796745ad708d712967818cf99c1da13ccdb94a with the changes mentionned here.

INLINE COMMENTS

> ApplicationSettings.cpp:89
>  
> -ApplicationSettings::ApplicationSettings(QObject *parent): QObject(parent),
> +ApplicationSettings::ApplicationSettings(QString path, QObject *parent): QObject(parent),
>       m_baseFontSizeMin(-7), m_baseFontSizeMax(7),

const reference

> ApplicationSettings.h:34
>  
> +#define GCOMPRIS_APPLICATION_NAME "gcompris-qt"
>  #define GC_DEFAULT_LOCALE "system"

you should not redefine it here but use the one on config.h
It may be different than gcompris-qt on some OS

> ApplicationSettingsMock.h:37
> +    {
> +        ApplicationSettings::setFullscreen(NULL);
> +        ApplicationSettings::setPreviousHeight(NULL);

In file included from tests/core/ApplicationSettingsTest.cpp:26:0:
tests/core/ApplicationSettingsMock.h: In constructor 'ApplicationSettingsMock::ApplicationSettingsMock()':
tests/core/ApplicationSettingsMock.h:38:31: warning: passing NULL to non-pointer argument 1 of 'void ApplicationSettings::setPreviousHeight(qint32)' [-Wconversion-null]

  setPreviousHeight(NULL);
                        ^

tests/core/ApplicationSettingsMock.h:39:30: warning: passing NULL to non-pointer argument 1 of 'void ApplicationSettings::setPreviousWidth(qint32)' [-Wconversion-null]

  setPreviousWidth(NULL);
                       ^

tests/core/ApplicationSettingsMock.h:40:29: warning: passing NULL to non-pointer argument 1 of 'void ApplicationSettings::setBaseFontSize(int)' [-Wconversion-null]

  setBaseFontSize(NULL);

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11034

To: himanshuvishwakarma, jjazeix, dmadaan, rudranilbasu, timotheegiet, #gcompris
Cc: #kde_edu, #gcompris, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180324/4c394698/attachment.html>