<table><tr><td style="">jjazeix accepted this revision.<br />jjazeix added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11034">View Revision</a></tr></table><br /><div><div><p>committed in <a href="https://commits.kde.org/gcompris/9a796745ad708d712967818cf99c1da13ccdb94a" class="remarkup-link" target="_blank" rel="noreferrer">https://commits.kde.org/gcompris/9a796745ad708d712967818cf99c1da13ccdb94a</a> with the changes mentionned here.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11034#inline-57628">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ApplicationSettings.cpp:89</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">ApplicationSettings</span><span style="color: #aa2211">::</span><span class="n">ApplicationSettings</span><span class="p">(</span><span class="n">QObject</span> <span style="color: #aa2211">*</span><span class="n">parent</span><span class="p">)</span><span style="color: #aa2211">:</span> <span class="n">QObject</span><span class="p">(</span><span class="n">parent</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">ApplicationSettings</span><span style="color: #aa2211">::</span><span class="n">ApplicationSettings</span><span class="p">(</span><span class="n">Q<span class="bright">String</span></span><span class="bright"> </span><span class="n"><span class="bright">path</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">Q</span>Object</span> <span style="color: #aa2211">*</span><span class="n">parent</span><span class="p">)</span><span style="color: #aa2211">:</span> <span class="n">QObject</span><span class="p">(</span><span class="n">parent</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_baseFontSizeMin</span><span class="p">(</span><span style="color: #aa2211">-</span><span style="color: #601200">7</span><span class="p">),</span> <span class="n">m_baseFontSizeMax</span><span class="p">(</span><span style="color: #601200">7</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const reference</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11034#inline-57626">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ApplicationSettings.h:34</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#define GCOMPRIS_APPLICATION_NAME "gcompris-qt"</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#define GC_DEFAULT_LOCALE "system"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you should not redefine it here but use the one on config.h<br />
It may be different than gcompris-qt on some OS</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11034#inline-57641">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ApplicationSettingsMock.h:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ApplicationSettings</span><span style="color: #aa2211">::</span><span class="n">setFullscreen</span><span class="p">(</span><span style="color: #304a96">NULL</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ApplicationSettings</span><span style="color: #aa2211">::</span><span class="n">setPreviousHeight</span><span class="p">(</span><span style="color: #304a96">NULL</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In file included from tests/core/ApplicationSettingsTest.cpp:26:0:<br />
tests/core/ApplicationSettingsMock.h: In constructor 'ApplicationSettingsMock::ApplicationSettingsMock()':<br />
tests/core/ApplicationSettingsMock.h:38:31: warning: passing NULL to non-pointer argument 1 of 'void ApplicationSettings::setPreviousHeight(qint32)' [-Wconversion-null]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">setPreviousHeight(NULL);
^</pre></div>
<p style="padding: 0; margin: 8px;">tests/core/ApplicationSettingsMock.h:39:30: warning: passing NULL to non-pointer argument 1 of 'void ApplicationSettings::setPreviousWidth(qint32)' [-Wconversion-null]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">setPreviousWidth(NULL);
^</pre></div>
<p style="padding: 0; margin: 8px;">tests/core/ApplicationSettingsMock.h:40:29: warning: passing NULL to non-pointer argument 1 of 'void ApplicationSettings::setBaseFontSize(int)' [-Wconversion-null]</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">setBaseFontSize(NULL);</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11034">https://phabricator.kde.org/D11034</a></div></div><br /><div><strong>To: </strong>himanshuvishwakarma, jjazeix, dmadaan, rudranilbasu, timotheegiet, GCompris<br /><strong>Cc: </strong>KDE Edu, GCompris, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin<br /></div>