D11485: Add readonly properties to AnswerButton.qml to check whether correct and wrong answer animations are running.

Aman Kumar Gupta noreply at phabricator.kde.org
Tue Mar 20 09:23:27 UTC 2018


amankumargupta added inline comments.

INLINE COMMENTS

> jjazeix wrote in AnswerButton.qml:42
> why don't you directly put blockClicks: correctAnswerAnimation.running || wrongAnswerAnimation.running
> and remove the assignment in correctAnswerAnimation?

Yes, this can be a solution and we can make it default.

But there may be some other situations in some activities during which we also would want to block buttons, along with the duration when animation is running, so these variables can come in handy for them when the activity needs to redefine blockClicks externally ?

Like, in Solar System activity, we also need to block it when the closeness meter animation is running.
Maybe there can be similar needs for activities in the future.

Example: in the activity -->** blockClicks: isCorrectAnswerAnimationRunning || isWrongAnswerAnimationRunning || someOtherConditionsInTheActivity**

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11485

To: amankumargupta, #gcompris_improvements
Cc: jjazeix, #kde_edu, #gcompris_improvements, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180320/5551684d/attachment-0001.html>


More information about the kde-edu mailing list