D11485: Add readonly properties to AnswerButton.qml to check whether correct and wrong answer animations are running.

Johnny Jazeix noreply at phabricator.kde.org
Tue Mar 20 06:55:11 UTC 2018


jjazeix added inline comments.

INLINE COMMENTS

> AnswerButton.qml:42
> +    // These can be used to check whether the correct answer and wrong answer animations are running or not.
> +    readonly property bool isCorrectAnswerAnimationRunning: correctAnswerAnimation.running
> +    readonly property bool isWrongAnswerAnimationRunning: wrongAnswerAnimation.running

why don't you directly put blockClicks: correctAnswerAnimation.running || wrongAnswerAnimation.running
and remove the assignment in correctAnswerAnimation?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11485

To: amankumargupta, #gcompris_improvements
Cc: jjazeix, #kde_edu, #gcompris_improvements, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180320/c734b414/attachment.html>


More information about the kde-edu mailing list