D11391: ecm_add_test method is added

[Himanshu Vishwakarma]

himanshuvishwakarma added inline comments.

INLINE COMMENTS

> jjazeix wrote in CMakeLists.txt:35
> I'd rather not force to install ECM if not needed for building the main executable.
> On other OS than linux, it may be difficult to find and install.

Okay, i will make it optional, If we make ECM as optional then our test will also be optional.

> jjazeix wrote in CMakeLists.txt:39
> do we really need KDEInstallDirs and KDECMakeSettings?

Yaa, I think so because of the without KDEInstallDirs and KDECMakeSettings, ecm_add_test method of the module ECMAddTests is not working. : )

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11391

To: himanshuvishwakarma, jjazeix, #gcompris, dmadaan, timotheegiet, echarruau
Cc: jjazeix, #gcompris, #kde_edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180316/8f3d5392/attachment.html>