D11391: ecm_add_test method is added

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> CMakeLists.txt:35
>  # cmake modules setup
> -find_package(ECM 1.4.0 QUIET NO_MODULE)
> +find_package(ECM REQUIRED NO_MODULE)
>  set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR} ${CMAKE_SOURCE_DIR}/cmake/)

I'd rather not force to install ECM if not needed for building the main executable.
On other OS than linux, it may be difficult to find and install.

> CMakeLists.txt:39
>  
> +include(KDEInstallDirs)
> +include(KDECMakeSettings)

do we really need KDEInstallDirs and KDECMakeSettings?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11391

To: himanshuvishwakarma, jjazeix, #gcompris, dmadaan, timotheegiet, echarruau
Cc: jjazeix, #gcompris, #kde_edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180316/2e3e4c11/attachment-0001.html>