D9360: Adding feature to change letters to capital and back (Ref: T5936)

[Johnny Jazeix]

jjazeix added a comment.


  Sorry for delay, there is still an issue with mixed case

INLINE COMMENTS

> LetterInWord.qml:69
>              property alias wordsModel: wordsModel
> +            property int currentLetterCase: 0
>              property int currentMode: normalModeWordCount

The default value should be the same as ApplicationSettings.fontCapitalization

> LetterInWord.qml:293
>                  font.weight: Font.DemiBold
> +                font.capitalization: {
> +                    if (items.currentLetterCase === Font.MixedCase) return Math.floor(Math.random() * 2)

after testing, it does not work as expected for MixedCase.
Basically, it's only computed once when changing (so it will either always be uppercase or lowercase) and it won't change when changing level/sublevel.
To handle all the cases, the capitalization should be set on the initLevel function.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9360

To: rohitdas, #gcompris, #gcompris_improvements, jjazeix
Cc: jjazeix, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180310/77a410ab/attachment-0001.html>