D13711: Support import of ROOT (CERN) TH1 histograms

[Stefan Gerlach]

sgerlach requested changes to this revision.
sgerlach added a comment.
This revision now requires changes to proceed.


  Your patch is excellent and of extreme high quality. Thank you.
  Can you check if "ROOT" can be put after "FITS"?

INLINE COMMENTS

> LiveDataSource.h:52
>  public:
> -	enum FileType {Ascii, Binary, Image, HDF5, NETCDF, FITS};
> +	enum FileType {Ascii, Binary, Image, HDF5, NETCDF, ROOT, FITS};
>  	enum SourceType {

Can "ROOT" be also put after "FITS"? This can avoid problems with older project files using FITS.

> ImportFileDialog.cpp:210
>  		LiveDataSource::FileType fileType = m_importFileWidget->currentFileType();
> -		if (fileType == LiveDataSource::HDF5)
> -			names = m_importFileWidget->selectedHDF5Names();
> -		else if (fileType == LiveDataSource::NETCDF)
> -			names = m_importFileWidget->selectedNetCDFNames();
> -
> -		//multiple extensions selected
> -
>  		// multiple data sets/variables for HDF5/NetCDF
> +		if (fileType == LiveDataSource::HDF5 ||

... and ROOT

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D13711

To: croick, sgerlach, asemke, fkristof
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180624/db190bb1/attachment.html>