<table><tr><td style="">sgerlach requested changes to this revision.<br />sgerlach added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13711">View Revision</a></tr></table><br /><div><div><p>Your patch is excellent and of extreme high quality. Thank you.<br />
Can you check if "ROOT" can be put after "FITS"?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13711#inline-71890">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LiveDataSource.h:52</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #a0a000">public</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span style="color: #aa4000">enum</span> <span class="n">FileType</span> <span class="p">{</span><span class="n">Ascii</span><span class="p">,</span> <span class="n">Binary</span><span class="p">,</span> <span class="n">Image</span><span class="p">,</span> <span class="n">HDF5</span><span class="p">,</span> <span class="n">NETCDF</span><span class="p">,</span> <span class="n">FITS</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">enum</span> <span class="n">FileType</span> <span class="p">{</span><span class="n">Ascii</span><span class="p">,</span> <span class="n">Binary</span><span class="p">,</span> <span class="n">Image</span><span class="p">,</span> <span class="n">HDF5</span><span class="p">,</span> <span class="n">NETCDF</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">ROOT</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">FITS</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">enum</span> <span class="n">SourceType</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can "ROOT" be also put after "FITS"? This can avoid problems with older project files using FITS.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13711#inline-71891">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ImportFileDialog.cpp:210</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">LiveDataSource</span><span style="color: #aa2211">::</span><span class="n">FileType</span> <span class="n">fileType</span> <span style="color: #aa2211">=</span> <span class="n">m_importFileWidget</span><span style="color: #aa2211">-></span><span class="n">currentFileType</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">fileType</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span class="n"><span class="bright">LiveDataSource</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">HDF5<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span style="color: #74777d"><span class="bright">// multiple data sets/variables for </span>HDF5<span class="bright">/NetCDF</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">fileType</span> <span style="color: #aa2211">==</span> <span class="n">LiveDataSource</span><span style="color: #aa2211">::</span><span class="n">HDF5</span> <span style="color: #aa2211">||</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">... and ROOT</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13711">https://phabricator.kde.org/D13711</a></div></div><br /><div><strong>To: </strong>croick, sgerlach, asemke, fkristof<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>