D13514: piano_composition, add a dialog to show warning before deleting all notes and other features

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> OptionsRow.qml:66
> +            background.currentType = optionsRow.noteLengthName[currentIndex][1]
> +            emitOptionMessage(qsTr("%1 note").arg(optionsRow.noteLengthName[currentIndex][0]))
> +        }

need a translator comment to understand what is %1.
I think it may be better to have "Whole note", "Half note" directly above instead of having "%1 note" here for translation purposes.

> OptionsRow.qml:95
>                  background.clefType = (background.clefType == "Bass") ? "Treble" : "Bass"
> +                emitOptionMessage(qsTr("%1 clef").arg(background.clefType === "Treble" ? qsTr("Treble") : qsTr("Bass")))
>                  lyricsArea.resetLyricsArea()

same as above, better have "Treble clef", "Bass clef"

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D13514

To: amankumargupta, #gcompris_activities
Cc: jjazeix, kde-edu, #gcompris_activities, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180613/d4960e63/attachment-0001.html>