<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13514">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13514#inline-70650">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OptionsRow.qml:66</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">background</span><span class="p">.</span><span style="color: #004012">currentType</span> <span style="color: #aa2211">=</span> <span style="color: #004012">optionsRow</span><span class="p">.</span><span style="color: #004012">noteLengthName</span><span class="p">[</span><span style="color: #004012">currentIndex</span><span class="p">][</span><span style="color: #601200">1</span><span class="p">]</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">emitOptionMessage</span><span class="p">(</span><span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"%1 note"</span><span class="p">).</span><span style="color: #004012">arg</span><span class="p">(</span><span style="color: #004012">optionsRow</span><span class="p">.</span><span style="color: #004012">noteLengthName</span><span class="p">[</span><span style="color: #004012">currentIndex</span><span class="p">][</span><span style="color: #601200">0</span><span class="p">]))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">need a translator comment to understand what is %1.<br />
I think it may be better to have "Whole note", "Half note" directly above instead of having "%1 note" here for translation purposes.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13514#inline-70652">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OptionsRow.qml:95</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">background</span><span class="p">.</span><span style="color: #004012">clefType</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span style="color: #004012">background</span><span class="p">.</span><span style="color: #004012">clefType</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"Bass"</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #766510">"Treble"</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"Bass"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">emitOptionMessage</span><span class="p">(</span><span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"%1 clef"</span><span class="p">).</span><span style="color: #004012">arg</span><span class="p">(</span><span style="color: #004012">background</span><span class="p">.</span><span style="color: #004012">clefType</span> <span style="color: #aa2211">===</span> <span style="color: #766510">"Treble"</span> <span style="color: #aa2211">?</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Treble"</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Bass"</span><span class="p">)))</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">lyricsArea</span><span class="p">.</span><span style="color: #004012">resetLyricsArea</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same as above, better have "Treble clef", "Bass clef"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13514">https://phabricator.kde.org/D13514</a></div></div><br /><div><strong>To: </strong>amankumargupta, GCompris: Activities<br /><strong>Cc: </strong>jjazeix, kde-edu, GCompris: Activities, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>