D14523: [import] Update file content overview after file type change
Alexander Semke
noreply at phabricator.kde.org
Tue Jul 31 20:28:42 BST 2018
asemke added inline comments.
INLINE COMMENTS
> ImportFileWidget.cpp:624
> void ImportFileWidget::fileNameChanged(const QString& name) {
> - QString fileName = name;
> -#ifndef HAVE_WINDOWS
> - // make relative path
> - if ( !fileName.isEmpty() && fileName.at(0) != QDir::separator())
> - fileName = QDir::homePath() + QDir::separator() + fileName;
> -#endif
> + QString fileName = absolutePath(name);
>
const QString& fileName
> ImportFileWidget.cpp:773
> + if (currentSourceType() == LiveDataSource::FileOrPipe) {
> + QString fileName = absolutePath(ui.leFileName->text());
> +
const QString& fileName
> ImportFileWidget.cpp:843
>
> - QString fileName = ui.leFileName->text();
> -#ifndef HAVE_WINDOWS
> - if (!fileName.isEmpty() && fileName.at(0) != QDir::separator())
> - fileName = QDir::homePath() + QDir::separator() + fileName;
> -#endif
> + QString fileName = absolutePath(ui.leFileName->text());
> DEBUG("refreshPreview(): file name = " << fileName.toStdString());
const QString& name
> ImportFileWidget.h:111
> void refreshPreview();
> + void updateContent(const QString&, int);
>
should this really be a slot?
REPOSITORY
R262 LabPlot
REVISION DETAIL
https://phabricator.kde.org/D14523
To: croick, #labplot
Cc: asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180731/95994e62/attachment.html>
More information about the kde-edu
mailing list