<table><tr><td style="">asemke added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14523">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14523#inline-76670">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ImportFileWidget.cpp:624</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #aa4000">void</span> <span class="n">ImportFileWidget</span><span style="color: #aa2211">::</span><span class="n">fileNameChanged</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">name</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span class="n">QString</span> <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="n">name</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">#ifndef HAVE_WINDOWS</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span style="color: #74777d">// make relative path</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span style="color: #aa4000">if</span> <span class="p">(</span> <span style="color: #aa2211">!</span><span class="n">fileName</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">fileName</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">)</span> <span style="color: #aa2211">!=</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">homePath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">fileName</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">#endif</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QString</span> <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">absolutePath</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">name<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span>;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const QString& fileName</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14523#inline-76672">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ImportFileWidget.cpp:773</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">currentSourceType</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">LiveDataSource</span><span style="color: #aa2211">::</span><span class="n">FileOrPipe</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="n">absolutePath</span><span class="p">(</span><span class="n">ui</span><span class="p">.</span><span class="n">leFileName</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const QString& fileName</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14523#inline-76673">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ImportFileWidget.cpp:843</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span class="n">QString</span> <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="n">ui</span><span class="p">.</span><span class="n">leFileName</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">#ifndef HAVE_WINDOWS</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">fileName</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span style="color: #aa2211">&&</span> <span class="n">fileName</span><span class="p">.</span><span class="n">at</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">)</span> <span style="color: #aa2211">!=</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">homePath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">fileName</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">#endif</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QString</span> <span class="n">fileName</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="n"><span class="bright">absolutePath</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">ui</span><span class="p">.</span><span class="n">leFileName</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">(<span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span class="n">DEBUG</span><span class="p">(</span><span style="color: #766510">"refreshPreview(): file name = "</span> <span style="color: #aa2211"><<</span> <span class="n">fileName</span><span class="p">.</span><span class="n">toStdString</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const QString& name</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14523#inline-76669">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ImportFileWidget.h:111</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">void</span> <span style="color: #004012">refreshPreview</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span style="color: #004012">updateContent</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span><span class="p">,</span> <span style="color: #aa4000">int</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">should this really be a slot?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14523">https://phabricator.kde.org/D14523</a></div></div><br /><div><strong>To: </strong>croick, LabPlot<br /><strong>Cc: </strong>asemke, kde-edu, narvaez, apol<br /></div>