D9942: T7614 Memory games patch

[Harry Mecwan]

harrymecwan added a comment.


  Okay so Animtim said that many of the activities have the same problem and he would like to take some time to come up with a general solution for this and until then it is better to patch it with the rectangular scores for vertical screens.

INLINE COMMENTS

> jjazeix wrote in MemoryCommon.qml:167
> you don't display anything on horizontal mode?

on Horizontal mode i display either "You" or "Score" and the score depending on whether it is 2 player or not.
on vertical mode it displays only the score.
i have attached the screenshot for that. 
https://cdn.pbrd.co/images/H3bWJlF.png

> jjazeix wrote in MemoryCommon.qml:190
> if the text is longer (because in another language, it has more characters), is the text contained in the rectangle or does it override?

it does not. i'll fix that. :)

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9942

To: harrymecwan, #gcompris_improvements, jjazeix, asagtani
Cc: #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180127/7b5e9fdb/attachment.html>