D9942: T7614 Memory games patch

[Johnny Jazeix]

jjazeix added a comment.


  Hi,
  have you checked the border line cases?
  Regarding the display itself, it would be better to check with Animtim on irc if we keep this or if we use the existing ScoreItem in core.

INLINE COMMENTS

> MemoryCommon.qml:167
>                  styleColor: "white"
> -                text: items.playerScore
> +                text: (background.isVertical ? "" : (activity.withTux ? "You: " : "Score: ")) + items.playerScore
>              }

qsTr() needed to translate string.
You can also use arg to have a better localisation.

> MemoryCommon.qml:167
>                  styleColor: "white"
> -                text: items.playerScore
> +                text: (background.isVertical ? "" : (activity.withTux ? "You: " : "Score: ")) + items.playerScore
>              }

you don't display anything on horizontal mode?

> MemoryCommon.qml:190
>  
>              GCText {
>                  id: tuxScore

if the text is longer (because in another language, it has more characters), is the text contained in the rectangle or does it override?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9942

To: harrymecwan, #gcompris_improvements, jjazeix, asagtani
Cc: #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180117/765eab20/attachment.html>