D17159: bug fix #400265: meridian flip check before capturing

[Jasem Mutlaq]

mutlaqja requested changes to this revision.
mutlaqja added a comment.
This revision now requires changes to proceed.


  Tested and it worked great. Few changes required.

INLINE COMMENTS

> capture.cpp:66
> +    // ensure that the mount interface is present
> +    mountInterface = new QDBusInterface("org.kde.kstars", "/KStars/Ekos/Mount", "org.kde.kstars.Ekos.Mount",
> +                                        QDBusConnection::sessionBus(), this);

Why are you initializing it here and then again in registerNewModule?

> skypoint.cpp:940
> +
> +QDBusArgument &operator<<(QDBusArgument &argument, const SkyPoint &source)
> +{

ditto

> skypoint.h:26
>  #include <QList>
> +#include <QtDBus/QtDBus>
>  

DBus is not used on KStars Lite, so #ifdef should be used

> skypoint.h:653
> +
> +Q_DECLARE_METATYPE(SkyPoint)
> +QDBusArgument &operator<<(QDBusArgument &argument, const SkyPoint &source);

ditto

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D17159

To: wreissenberger, TallFurryMan, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181228/c1252812/attachment.html>