D17697: Fix the list of file types in Kig "Open File" dialog

Yuri Chornoivan noreply at phabricator.kde.org
Thu Dec 20 13:50:08 GMT 2018


yurchor added a comment.


  In D17697#379954 <https://phabricator.kde.org/D17697#379954>, @pino wrote:
  
  > In D17697#379952 <https://phabricator.kde.org/D17697#379952>, @yurchor wrote:
  >
  > > In D17697#379949 <https://phabricator.kde.org/D17697#379949>, @pino wrote:
  > >
  > > > instead of nullifying the MIME types provided by the filters.
  > >
  > >
  > > Please explain this part. Thanks in advance.
  >
  >
  > Filtering by MIME type is not the same as filtering by extension. MIME type detection is based on extension //and// content, which makes file identification much better.
  
  
  That code is almost literally borrowed from the official Qt example. It does exactly what you are saying + allows to open "All files" if the detection fails. But Ok, you hate me and I will rewrite it as you wish.

REPOSITORY
  R331 Kig

REVISION DETAIL
  https://phabricator.kde.org/D17697

To: yurchor, #kde_edu, pino
Cc: pino, apol, kde-edu, narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181220/a6a87d08/attachment.html>


More information about the kde-edu mailing list