D17507: Chess activity: display list of taken pieces

[Johnny Jazeix]

jjazeix added a comment.


  Thank you for the patch.
  When you change level, the taken pieces are not resetted.

INLINE COMMENTS

> Chess.qml:169
> +                                blackTakenPieces.takenPiecesModel.remove(blackTakenPieces.takenPiecesModel.count-1)
> +                            } movesNum++
> +                            if(whiteTakenPieces.pushedLast[whiteTakenPieces.pushedLast.length-1] == movesNum) {

movesNum++ should be on the next line, it's quite easy to miss it after the '}'

> TakenPieces.qml:1
> +/* GCompris - chess.qml
> + *

neded to change filename and the year 2 lines below.
Maybe be better if the Item is named TakenPiecesList, as it is the list of taken pieces that is displayed.

> TakenPieces.qml:22
> +
> +import QtQuick 2.0
> +import "chess.js" as Activity

2.6

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17507

To: smitpatil, #gcompris_improvements
Cc: jjazeix, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20181211/30ae33bd/attachment-0001.html>