<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17507">View Revision</a></tr></table><br /><div><div><p>Thank you for the patch.<br />
When you change level, the taken pieces are not resetted.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17507#inline-96156">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Chess.qml:169</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                <span style="color: #004012">blackTakenPieces</span><span class="p">.</span><span style="color: #004012">takenPiecesModel</span><span class="p">.</span><span style="color: #004012">remove</span><span class="p">(</span><span style="color: #004012">blackTakenPieces</span><span class="p">.</span><span style="color: #004012">takenPiecesModel</span><span class="p">.</span><span style="color: #004012">count</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span class="p">}</span> <span style="color: #004012">movesNum</span><span style="color: #aa2211">++</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">whiteTakenPieces</span><span class="p">.</span><span style="color: #004012">pushedLast</span><span class="p">[</span><span style="color: #004012">whiteTakenPieces</span><span class="p">.</span><span style="color: #004012">pushedLast</span><span class="p">.</span><span style="color: #004012">length</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span style="color: #004012">movesNum</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">movesNum++ should be on the next line, it's quite easy to miss it after the '}'</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17507#inline-96150">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TakenPieces.qml:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/* GCompris - chess.qml</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">neded to change filename and the year 2 lines below.<br />
Maybe be better if the Item is named TakenPiecesList, as it is the list of taken pieces that is displayed.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17507#inline-96151">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TakenPieces.qml:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span> <span style="color: #601200">2.0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #766510">"chess.js"</span> <span style="color: #004012">as</span> <span style="color: #004012">Activity</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">2.6</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17507">https://phabricator.kde.org/D17507</a></div></div><br /><div><strong>To: </strong>smitpatil, GCompris: Improvements<br /><strong>Cc: </strong>jjazeix, kde-edu, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>