D14813: Adding XPlanet Viewer
noreply at phabricator.kde.org
Sat Aug 18 18:58:58 BST 2018
lancaster added a comment.
I can still make more changes to the code if needed. Many of the things you mention though that are left are not actually my doing due to the fact that it was already that way in the existing code before I started. If they need to be changed in this code, they should be changed elsewhere as well. I did these things the way I thought we were already doing them.
i18n string puzzles
I'm not sure what you mean by this. I think I did the i18n translations for the tooltips and other messages the way they were done elsewhere. I got rid of the words on the buttons. There might be some more needed in the xplanet options. Is that what you mean? I'm not sure what you mean by puzzles.
hardcoded /tmp, totally unsafe temporary file name creation for the FIFO
I got this method of creating the temp fifo file from Servermanager.cpp. I thought I did it the same way. If it is wrong here, it is probably wrong there.
wrong handling of non local URLs (which in fact that not supported)
This code was already in the ImageViewer for saving the file. I didn't change it much. Would it be better to copy the code for saving from one of the other places files are saved in KStars such as fits viewer? If so, which code do you consider good?
hardcoded size for buttons
Jasem has set the minimum and maximum size for the buttons to either 32 or 22 for a very large number of buttons in Ekos. Basically any time he put icons on the buttons. Is this not the way we are doing it?
To: lancaster, mutlaqja, pino
Cc: pino, mutlaqja, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the kde-edu