D14738: Add the markdown entry
Pino Toscano
noreply at phabricator.kde.org
Mon Aug 13 19:14:38 BST 2018
pino added a comment.
In D14738#307493 <https://phabricator.kde.org/D14738#307493>, @asemke wrote:
> In D14738#307471 <https://phabricator.kde.org/D14738#307471>, @pino wrote:
>
> > Please no embedded copies of 3rdparty libraries.
> > Also, okular already uses the Discount library <http://www.pell.portland.or.us/~orc/Code/discount/> for its markdown backend, so what about using it instead?
>
>
> @pino How is Discount used in okular? As an external optional dependency? I don't see it mentioned nowhere in https://cgit.kde.org/okular.git/tree/CMakeLists.txt .
In the okular sources, see:
- `cmake/modules/FindDiscount.cmake`
- `generators/CMakeLists.txt`
- the whole `generators/markdown` subdirectory
In D14738#307698 <https://phabricator.kde.org/D14738#307698>, @kqwyf wrote:
> In D14738#307471 <https://phabricator.kde.org/D14738#307471>, @pino wrote:
>
> > Please no embedded copies of 3rdparty libraries.
> > Also, okular already uses the Discount library <http://www.pell.portland.or.us/~orc/Code/discount/> for its markdown backend, so what about using it instead?
>
>
> I'm sorry but I'm not familiar with the various ways to include the 3rdparty libraries. How to use a library like Discount without enbedding it? Maybe loading it at runtime as a .so file?
There are plenty of libraries that cantor can optionally use, beside Qt and KF5 -- for example: libspectre, R, Qalculate, luajit, libpython. See the various cmake search module in the `cmake/` subdirectory, and the various searches (hint: `git grep -niw find_package`).
Basically, it is about finding the library (its headers and its development .so symlinks) at build time, and link against it. Again, plently of examples in cantor already.
REPOSITORY
R55 Cantor
REVISION DETAIL
https://phabricator.kde.org/D14738
To: kqwyf, pino, #cantor
Cc: filipesaraiva, pino, asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180813/d98f47ff/attachment.html>
More information about the kde-edu
mailing list