<table><tr><td style="">pino added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14738">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14738#307493" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14738#307493</a>, <a href="https://phabricator.kde.org/p/asemke/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@asemke</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14738#307471" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14738#307471</a>, <a href="https://phabricator.kde.org/p/pino/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@pino</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Please no embedded copies of 3rdparty libraries.<br />
Also, okular already uses the <a href="http://www.pell.portland.or.us/~orc/Code/discount/" class="remarkup-link" target="_blank" rel="noreferrer">Discount library</a> for its markdown backend, so what about using it instead?</p></div>
</blockquote>
<p><a href="https://phabricator.kde.org/p/pino/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@pino</a> How is Discount used in okular? As an external optional dependency? I don't see it mentioned nowhere in <a href="https://cgit.kde.org/okular.git/tree/CMakeLists.txt" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/okular.git/tree/CMakeLists.txt</a> .</p></div>
</blockquote>
<p>In the okular sources, see:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">cmake/modules/FindDiscount.cmake</tt></li>
<li class="remarkup-list-item"><tt style="background: #ebebeb; font-size: 13px;">generators/CMakeLists.txt</tt></li>
<li class="remarkup-list-item">the whole <tt style="background: #ebebeb; font-size: 13px;">generators/markdown</tt> subdirectory</li>
</ul>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14738#307698" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14738#307698</a>, <a href="https://phabricator.kde.org/p/kqwyf/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@kqwyf</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14738#307471" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14738#307471</a>, <a href="https://phabricator.kde.org/p/pino/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@pino</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Please no embedded copies of 3rdparty libraries.<br />
Also, okular already uses the <a href="http://www.pell.portland.or.us/~orc/Code/discount/" class="remarkup-link" target="_blank" rel="noreferrer">Discount library</a> for its markdown backend, so what about using it instead?</p></div>
</blockquote>
<p>I'm sorry but I'm not familiar with the various ways to include the 3rdparty libraries. How to use a library like Discount without enbedding it? Maybe loading it at runtime as a .so file?</p></div>
</blockquote>
<p>There are plenty of libraries that cantor can optionally use, beside Qt and KF5 -- for example: libspectre, R, Qalculate, luajit, libpython. See the various cmake search module in the <tt style="background: #ebebeb; font-size: 13px;">cmake/</tt> subdirectory, and the various searches (hint: <tt style="background: #ebebeb; font-size: 13px;">git grep -niw find_package</tt>).<br />
Basically, it is about finding the library (its headers and its development .so symlinks) at build time, and link against it. Again, plently of examples in cantor already.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14738">https://phabricator.kde.org/D14738</a></div></div><br /><div><strong>To: </strong>kqwyf, pino, Cantor<br /><strong>Cc: </strong>filipesaraiva, pino, asemke, kde-edu, narvaez, apol<br /></div>