D14712: Play_piano activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> ActivityInfo.qml:40
> +  //: Help manual
> +  manual: qsTr("The notes you see will be played to you. Click on the corresponding keys on the keyboard that match the notes you hear and see.<br>Levels 1-5 will offer treble clef to practice and levels 6-10 will offer bass clef.<br>Each level has 5 sublevels.")
> +  credit: ""

no need to say each level has 5 sublevels, there is the score showing it

> PlayPiano.qml:67
> +            if(piano.whiteKeysEnabled && !iAmReady.visible) {
> +                if(event.key === Qt.Key_1) {
> +                    piano.keyRepeater.itemAt(0).whiteKey.keyPressed()

factorisation

> PlayPiano.qml:121
> +                    keyNumber--
> +                if(!keyNumber)
> +                    piano.keyRepeater.itemAt(i).blackKey.keyPressed()

use comparisons if you compare integers to 0

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D14712

To: amankumargupta, #gcompris_activities
Cc: jjazeix, kde-edu, #gcompris_activities, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180812/dd109cc2/attachment-0001.html>