<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14712">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14712#inline-78174">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActivityInfo.qml:40</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #74777d">//: Help manual</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">manual:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"The notes you see will be played to you. Click on the corresponding keys on the keyboard that match the notes you hear and see.<br>Levels 1-5 will offer treble clef to practice and levels 6-10 will offer bass clef.<br>Each level has 5 sublevels."</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">credit:</span> <span style="color: #766510">""</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no need to say each level has 5 sublevels, there is the score showing it</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14712#inline-78173">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PlayPiano.qml:67</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">piano</span><span class="p">.</span><span style="color: #004012">whiteKeysEnabled</span> <span style="color: #aa2211">&&</span> <span style="color: #aa2211">!</span><span style="color: #004012">iAmReady</span><span class="p">.</span><span style="color: #004012">visible</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">event</span><span class="p">.</span><span style="color: #004012">key</span> <span style="color: #aa2211">===</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">Key_1</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #004012">piano</span><span class="p">.</span><span style="color: #004012">keyRepeater</span><span class="p">.</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">).</span><span style="color: #004012">whiteKey</span><span class="p">.</span><span style="color: #004012">keyPressed</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">factorisation</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D14712#inline-78175">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PlayPiano.qml:121</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #004012">keyNumber</span><span style="color: #aa2211">--</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #aa2211">!</span><span style="color: #004012">keyNumber</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #004012">piano</span><span class="p">.</span><span style="color: #004012">keyRepeater</span><span class="p">.</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #004012">i</span><span class="p">).</span><span style="color: #004012">blackKey</span><span class="p">.</span><span style="color: #004012">keyPressed</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use comparisons if you compare integers to 0</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14712">https://phabricator.kde.org/D14712</a></div></div><br /><div><strong>To: </strong>amankumargupta, GCompris: Activities<br /><strong>Cc: </strong>jjazeix, kde-edu, GCompris: Activities, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>