D14653: note_names

[emmanuel charruau]

echarruau added inline comments.

INLINE COMMENTS

> NoteNames.qml:280
> +            Repeater {
> +                id: octaveRepeater
> +                anchors.fill: parent

I have a problem when I want to play a B3 <https://phabricator.kde.org/B3>. I should have two keyboards present on the screen. C3 <https://phabricator.kde.org/C3>-B3 keyboard under C4-B4, I can this way play a C4 and B3 <https://phabricator.kde.org/B3> without using the arrows. At the moment I have just the C3 <https://phabricator.kde.org/C3>-B3 alone on the top position and this is not playable.

Same problem in horizontal mode where I have only C3 <https://phabricator.kde.org/C3>-B3 on the right of the screen. I should see the two octaves C3 <https://phabricator.kde.org/C3>-B3 and C4-B4.

> NoteNames.qml:283
> +                model: doubleOctave.nbJointKeyboards
> +                Piano {
> +                    id: pianoKeyboard

It would be good to rename Piano element as PianoOctaveKeyboard

> NoteNames.qml:362
> +            visible: (doubleOctave.currentOctaveNb < doubleOctave.maxNbOctaves - 1) && doubleOctave.visible
> +            anchors {
> +                verticalCenter: doubleOctave.verticalCenter

can you try to make the arrows bigger and put them over the keyboard, you gain some place to extend the size of the keyboardon the left and on the right, bigger the keys will be better it will be.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D14653

To: amankumargupta, #gcompris_activities
Cc: echarruau, jjazeix, kde-edu, #gcompris_activities, harrymecwan, ganeshredcobra, nityanandkumar, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180806/2dacc991/attachment.html>