D14653: note_names

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> AdvancedTimer.qml:22
> +import QtQuick 2.6
> +import QtQuick.Controls 1.0
> +import GCompris 1.0

1.5

> NoteNames.qml:224
> +
> +            property int percentage: 0
> +

can it be an alias of the value?

> NoteNames.qml:241
> +                color: "black"
> +                text: parent.value + '%'
> +                z: 2

it still needs qsTr(). In French, there is a space between the number and the %

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D14653

To: amankumargupta, #gcompris_activities
Cc: jjazeix, kde-edu, #gcompris_activities, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180806/ddaf6da2/attachment-0001.html>