D12565: Improve octave login

[Alexander Semke]

asemke added a comment.


  Cleaning up in logout() is ok. Sending emit loginDone() in readOutput() is not very clean. Everything login related should be done in login().  What do you mean with "we emit this signal before we real finish preparation"? Is  m_process->waitForReadyRead(); in OctaveSession::login() not enough to collect and to parse the initial output of octave?

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D12565

To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180428/ced235ce/attachment.html>