D12565: Improve octave login
Nikita Sirgienko
noreply at phabricator.kde.org
Fri Apr 27 19:56:09 UTC 2018
sirgienko created this revision.
sirgienko added reviewers: Cantor, asemke.
sirgienko added a project: Cantor.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.
sirgienko requested review of this revision.
REVISION SUMMARY
Before, when we work with octave and use 'Restart Backend' button, we suddenly get foreign output. So this commit fix it by adding backend cleanup of inner state in logout. Also the commit move `emit loginDone` statement, because we emit this signal **before** we real finish preparation.
TEST PLAN
1. Run octave backend without patch
2. Write some entries and run they
3. Reboot octave backend by the button and check, that the output changes
4. Apply patch
5. Check, that now all fine.
REPOSITORY
R55 Cantor
BRANCH
improve-octave-login
REVISION DETAIL
https://phabricator.kde.org/D12565
AFFECTED FILES
src/backends/octave/octavesession.cpp
To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180427/068e89df/attachment.html>
More information about the kde-edu
mailing list