D7373: Added Easy Mode(ref: T5937)

Johnny Jazeix noreply at phabricator.kde.org
Thu Nov 2 19:03:40 UTC 2017

jjazeix added inline comments.


> LetterInWord.qml:69
>              property alias wordsModel: wordsModel
> +            property int mode
>              property GCAudio audioVoices: activity.audioVoices

you can rename it to be more precise on what it does
and have "readonly int" variables to name the possible values (reading 5 and 11 at multiple places does not help to know where these values come from and if they are linked or not)

> LetterInWord.qml:171
> +                items.mode = dialogActivityConfig.loader.item.easyModeConfig.checked ? 5 : 11
> +                dataToSave["modes"] = items.mode
> +

"modes" can be renamed to be more precise

  R2 GCompris


To: rohitdas, #gcompris, #gcompris_improvements
Cc: #kde_edu, dmadaan, jjazeix, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20171102/d59d8d90/attachment.html>

More information about the kde-edu mailing list