<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7373" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7373#inline-37784" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LetterInWord.qml:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #004012">property</span> <span style="color: #004012">alias</span> <span style="color: #aa4000">wordsModel:</span> <span style="color: #004012">wordsModel</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #004012">property</span> <span style="color: #304a96">int</span> <span style="color: #004012">mode</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #004012">property</span> <span style="color: #004012">GCAudio</span> <span style="color: #aa4000">audioVoices:</span> <span style="color: #004012">activity</span><span class="p">.</span><span style="color: #004012">audioVoices</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can rename it to be more precise on what it does<br />
and have "readonly int" variables to name the possible values (reading 5 and 11 at multiple places does not help to know where these values come from and if they are linked or not)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D7373#inline-37786" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LetterInWord.qml:171</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">mode</span> <span style="color: #aa2211">=</span> <span style="color: #004012">dialogActivityConfig</span><span class="p">.</span><span style="color: #004012">loader</span><span class="p">.</span><span style="color: #004012">item</span><span class="p">.</span><span style="color: #004012">easyModeConfig</span><span class="p">.</span><span style="color: #004012">checked</span> <span style="color: #aa2211">?</span> <span style="color: #601200">5</span> <span style="color: #aa2211">:</span> <span style="color: #601200">11</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #004012">dataToSave</span><span class="p">[</span><span style="color: #766510">"modes"</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">mode</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"modes" can be renamed to be more precise</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7373" rel="noreferrer">https://phabricator.kde.org/D7373</a></div></div><br /><div><strong>To: </strong>rohitdas, GCompris, GCompris: Improvements<br /><strong>Cc: </strong>KDE Edu, dmadaan, jjazeix, narvaez, apol<br /></div>