Review Request 130125: parley: Fix invisible color text in statistics legend
Dimitris Kardarakos
dimkard at gmail.com
Wed Jul 26 08:01:04 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130125/
-----------------------------------------------------------
(Updated July 26, 2017, 8:01 a.m.)
Review request for KDE Edu and Hartmut Riesenbeck.
Changes
-------
Color is set using QPalette::WindowText
Repository: parley
Description
-------
Since text color in statistics legend had been set to black, it was invisible when dark themes were used. With this fix, text color follows the user selected color theme.
Diffs (updated)
-----
src/statistics/statisticslegendwidget.cpp 3195a0a
Diff: https://git.reviewboard.kde.org/r/130125/diff/
Testing
-------
Legend is displayed properly using Breeze or Breeze Dark.
File Attachments (updated)
----------------
Legend before
https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/1d4dee19-6923-4d71-a1cf-e84f204b5415__legend_before.png
Legend after
https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/4785afd7-120b-4a74-aaf9-7902222e6b6f__legend_after.png
Legend before
https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/199e1858-fcd7-41fb-a81c-2d9bb129d1b9__legend_before.png
Legend after
https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/763669bb-a161-48a1-a08e-2da8d8295e78__legend_after.png
fixLegendColor.patch
https://git.reviewboard.kde.org/media/uploaded/files/2017/07/26/8027a0f5-3597-4238-9d39-c44068b3ca15__fixLegendColor.patch
fixLegendColor.patch
https://git.reviewboard.kde.org/media/uploaded/files/2017/07/26/cd9c211b-c938-49ce-9541-e1036d57be36__fixLegendColor.patch
Thanks,
Dimitris Kardarakos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170726/3e296769/attachment.html>
More information about the kde-edu
mailing list