Review Request 130125: parley: Fix invisible color text in statistics legend

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130125/#review103399
-----------------------------------------------------------




src/statistics/statisticslegendwidget.cpp (line 101)
<https://git.reviewboard.kde.org/r/130125/#comment68818>

    I actually think the proper color is QPalette().color(QPalette::WindowText)


- Albert Astals Cid


On mai. 11, 2017, 8:48 a.m., Dimitris Kardarakos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130125/
> -----------------------------------------------------------
> 
> (Updated mai. 11, 2017, 8:48 a.m.)
> 
> 
> Review request for KDE Edu and Hartmut Riesenbeck.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Since text color in statistics legend had been set to black, it was invisible when dark themes were used. With this fix, text color follows the user selected color theme.
> 
> 
> Diffs
> -----
> 
>   src/statistics/statisticslegendwidget.cpp 3195a0a 
> 
> Diff: https://git.reviewboard.kde.org/r/130125/diff/
> 
> 
> Testing
> -------
> 
> Legend is displayed properly using Breeze or Breeze Dark.
> 
> 
> File Attachments
> ----------------
> 
> Legend before
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/1d4dee19-6923-4d71-a1cf-e84f204b5415__legend_before.png
> Legend after
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/4785afd7-120b-4a74-aaf9-7902222e6b6f__legend_after.png
> Legend before
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/199e1858-fcd7-41fb-a81c-2d9bb129d1b9__legend_before.png
> Legend after
>   https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/763669bb-a161-48a1-a08e-2da8d8295e78__legend_after.png
> 
> 
> Thanks,
> 
> Dimitris Kardarakos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20170702/98035a3b/attachment.html>