Review Request 128975: Fix faulty assignment and equal to operator of KEduVocText

Hartmut Riesenbeck hartmut.riesenbeck at gmx.de
Thu Sep 22 18:29:36 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128975/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 6:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Changes
-------

Submitted with commit e410bd83ea425a43686394a38c881d5cfb341697 by Hartmut Riesenbeck to branch master.


Repository: libkeduvocdocument


Description
-------

The two members m_preGrade and m_interval were not copied by the
assignment operator nor were compared by the equal to operator of the
KEduVocText class.


Diffs
-----

  keduvocdocument/autotests/CMakeLists.txt 679a5f6da25e24fcb064bb612dd0f9d783284e37 
  keduvocdocument/autotests/keduvoctexttest.h PRE-CREATION 
  keduvocdocument/autotests/keduvoctexttest.cpp PRE-CREATION 
  keduvocdocument/keduvoctext.h 7a7408a5ec264af750faf106ac24a31df274d426 
  keduvocdocument/keduvoctext.cpp 6205106718efb59140037b1513f149a9ecc4fa2f 

Diff: https://git.reviewboard.kde.org/r/128975/diff/


Testing
-------

Test methods to check correct behaviour were added to autotests.


Thanks,

Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160922/a8770c88/attachment.html>


More information about the kde-edu mailing list