Review Request 128975: Fix faulty assignment and equal to operator of KEduVocText

Jeremy Whiting jpwhiting at kde.org
Wed Sep 21 20:10:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128975/#review99394
-----------------------------------------------------------


Ship it!




Ship It!

- Jeremy Whiting


On Sept. 21, 2016, 6:47 a.m., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128975/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 6:47 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> The two members m_preGrade and m_interval were not copied by the
> assignment operator nor were compared by the equal to operator of the
> KEduVocText class.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/autotests/CMakeLists.txt 679a5f6da25e24fcb064bb612dd0f9d783284e37 
>   keduvocdocument/autotests/keduvoctexttest.h PRE-CREATION 
>   keduvocdocument/autotests/keduvoctexttest.cpp PRE-CREATION 
>   keduvocdocument/keduvoctext.h 7a7408a5ec264af750faf106ac24a31df274d426 
>   keduvocdocument/keduvoctext.cpp 6205106718efb59140037b1513f149a9ecc4fa2f 
> 
> Diff: https://git.reviewboard.kde.org/r/128975/diff/
> 
> 
> Testing
> -------
> 
> Test methods to check correct behaviour were added to autotests.
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160921/14d6d822/attachment-0001.html>


More information about the kde-edu mailing list