Review Request 123968: Simplify Finding GSL in CMake

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/#review100307
-----------------------------------------------------------


Ship it!




What's the status of this now?

As there's still no concept for KDE/CI on OSX, please commit if it works fine on Linux & Windows!

- Marko Käning


On June 30, 2015, 12:41 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123968/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 12:41 p.m.)
> 
> 
> Review request for KDE Edu and Marko Käning.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> Use the PkgConfig module. Setting compile definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 980909c5b7b3effe70f0478f5e2128870f342e8f 
>   src/CMakeLists.txt a70299a6b29dbf6703d255f7b9b1c05b4a457da1 
> 
> Diff: https://git.reviewboard.kde.org/r/123968/diff/
> 
> 
> Testing
> -------
> 
> Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this still works in the OSX configuration, Marko?
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20161026/6b7fa1a5/attachment.html>